mithril-aggregator/src/commands/protocol_configuration_command.rs:345

• User-facing CLI output contains spelling/grammar issues ("Sucessfuly write"), which makes the command output look unpolished.

        println!(
            "Sucessfuly write Tx datum file at {}",
            self.target_path.to_string_lossy()
        );

internal/mithril-protocol-config/src/cardano_chain/protocol_configuration_reader.rs:45

• CardanoChainProtocolConfigurationMarkersReader::read is wired for ExecutionEnvironment::Production (via DependenciesBuilder::build_protocol_configuration_reader) but currently always returns an "not implemented yet" error. This means the new production CLI commands will fail at runtime, and it contradicts the PR/issue requirement to read on-chain markers.

    async fn read(&self) -> StdResult<ConfigurationComputerFromMarkers> {
        //read payload
        // to ProtocolConfigurationForEpochMessage
        // to ProtocolConfigurationForEpoch
        // build ConfigurationComputerFromMarkers with ProtocolConfigurationForEpoch
        Err(anyhow::anyhow!(
            "CardanoChainProtocolConfigurationMarkersReader::read is not implemented yet"
        ))

mithril-aggregator/src/commands/protocol_configuration_command.rs:345

• Typo in user-facing output: "Sucessfully" should be "Successfully".

        println!(
            "Sucessfully wrote Tx datum file at {}",
            self.target_path.to_string_lossy()
        );

mithril-aggregator/src/commands/protocol_configuration_command.rs:310

• fs::read_to_string is stored as a Result and then immediately ?-unwrapped inside serde_json::from_str. This is harder to read than unwrapping once and passing the String to serde.

        let json_protocol_configurations = fs::read_to_string(&self.import_path);

        //2 - Parse the json into a protocol configuration list using serde_json
        println!("Json parsing ...");
        let protocol_configurations: Vec<HumanReadableProtocolConfiguration> =
            serde_json::from_str(&json_protocol_configurations?)?;

mithril-aggregator/src/tools/protocol_configuration.rs:157

• This tool code uses println! for reporting datum size even though the rest of the module uses slog logging. Using the logger keeps output consistent and configurable (and avoids mixing stdout/stderr in services).

        println!("Datum size: {:.2} KB", size_kb);

mithril-aggregator/src/tools/protocol_configuration.rs:31

• Typo in error message: "the same has configuration" should be "the same as configuration".

    #[error("Configuration to import for {0:?} is not the same has configuration on chain")]
    NotSameConfigurationForEpoch(Epoch),

mithril-aggregator/src/commands/protocol_configuration_command.rs:227

• Typo in user-facing output: "Sucessfully" should be "Successfully".

This issue also appears on line 342 of the same file.

        println!(
            "Sucessfully wrote JSON protocol configurations file at {}",
            self.target_path.to_string_lossy()
        );

mithril-aggregator/src/tools/protocol_configuration.rs:83

• get_on_chain_configurations(self) consumes the whole ProtocolConfigurationTools, which is surprising for a getter and prevents calling other methods afterward. Consider taking &self and returning a clone (or returning a reference) so the tools instance remains usable.

    pub fn get_on_chain_configurations(self) -> ConfigurationComputerFromMarkers {
        self.configuration.on_chain_configurations
    }

mithril-aggregator/src/configuration.rs:204

• This newly added ConfigurationSource::protocol_configuration_reader_parameters default implementation uses panic!. Since this method is used to build production dependencies, leaving it as a panicking default increases the risk of runtime crashes if an implementation forgets to override it. Prefer making it a required method (no default) or returning a Result with a proper error.

    /// Protocol configuration reader adapter parameters
    fn protocol_configuration_reader_parameters(&self) -> ProtocolConfigurationReaderParameters {
        panic!("protocol_configuration_reader_parameters is not implemented.");
    }

internal/mithril-protocol-config/src/cardano_chain/payload.rs:93

• ProtocolConfigurationMarkersPayload::sign maps serialization errors from message_to_bytes() into CreateSignature, which misclassifies the failure (and discards the more specific SerializeMessage variant). The serialization error should be propagated as-is before signing.

        let signature =
            signer.sign(&self.message_to_bytes().map_err(|e| {
                ProtocolConfigurationMarkersPayloadError::CreateSignature(e.into())
            })?);

mithril-aggregator/src/commands/protocol_configuration_command.rs:3

• Map and Value are imported from config but never used in this file; this will trigger unused-import warnings (CI should be warning-free).

This issue also appears on line 305 of the same file.

use config::{ConfigBuilder, Map, Value, builder::DefaultState};